Fix the bbolt round trip, the blocklist gaps and the deploy set
The cache snapshot never loaded, so every restart was a cold cache. Snapshot
packed the whole key while Load decoded the record header out of the key's
remainder instead of the value, so every entry was skipped. The two sides are
now an explicit encodeRecord/decodeRecord pair with a version byte and a CRC-32C
trailer, so a future format change is detected instead of silently misparsed.
Load also drops entries that are already past ExpiresAt and rewrites the TTL to
the time actually left, so a served TTL never jumps back up across a restart.
Blocklist, all six gaps the failing tests were pointing at: a leading UTF-8 BOM
is stripped, "!allow example.com" works, SourceMeta exists for a source that
only ever contributed a rule, Pattern() reports the bare name again (the new
WireName() produces the wildcard form for the API), an RPZ record with no
explicit TTL inherits the zone default instead of whatever the reader left in
the RR, a hosts line with no address in the first field says so, and the
adblock parser handles CRLF and adblock-flavoured lines pasted into a plain
list. TestHolderSwapIsAtomic was asserting the wrong invariant — the swap was
always atomic, a name blocked by the old set is legitimately unblocked by the
new one.
Tests added for acl and resolver, both of which turned up real bugs:
- a PTR suffix matched across label boundaries, so a group scoped to
example.com. also swallowed ample.com. and notexample.com. — a client could
land in a group it does not belong to;
- the "*" catch-all was dropped from the rendered domain patterns, so the
engine's per-query recompile lost the "everything" case;
- Upstream.Success never closed an open breaker, so a recovered upstream stayed
excluded for the full cooldown;
- Exchange fanned out in parallel even under policy: failover.
Deploy set: go.mod requires Go 1.27.1 but CI pinned 1.23 and the Dockerfile
pinned golang:1.23-alpine, so neither could have built. The Dockerfile also
copied the source tree after the console bundle, which clobbered it.
The k8s set asked for hostNetwork with two replicas, but the server never sets
SO_REUSEPORT, so the second pod could not bind :53 and would crash-loop. It now
runs without hostNetwork behind a LoadBalancer Service, with a separate
ClusterIP Service for the Ingress (a headless Service cannot back one), a
ServiceAccount, an API-key Secret, per-pod PVCs, and a kustomization. The HPA
is gone: it cannot drive a StatefulSet. To let the API key come from that
Secret, config.Load now expands ${VAR} / ${VAR:-default} / ${NAME-default} and
fails to start on an unset variable with no default, so a missing secret is a
crash loop rather than an unauthenticated console. Expansion skips YAML
comments, so documenting ${VAR} in the ConfigMap does not break the file.
Verified: gofmt, go build, go vet clean; go test -race ./internal/... green
(acl, app, blocklist, cache, config, resolver, zonefile).
This commit is contained in:
1 parent
3bcc10a029
commit
26134ba437
22 files changed
+3106
-225
No files matched your search
@@ -290,6 +290,15 @@ func (b *Builder) Add(r Rule, source string, categories []string) {
|
||||
m[name] = e
|
||||
b.countAction(e, 1)
|
||||
b.noteOrder(source)
|
||||
// A source that only ever contributed rules (an inline blocklist entry, or
|
||||
// a list whose bookkeeping was never noted) is still a source: the UI
|
||||
// lists sources, and a rule with a source nobody has heard of would show
|
||||
// up as a blank column.
|
||||
if source != "" {
|
||||
if _, ok := b.meta[source]; !ok {
|
||||
b.meta[source] = SourceMeta{Name: source}
|
||||
}
|
||||
}
|
||||
}
|
||||
|
||||
// metaFor reports whether a source already contributed to this build.
|
||||
@@ -622,8 +631,20 @@ func (k PatternKind) String() string {
|
||||
}
|
||||
}
|
||||
|
||||
// Pattern renders a pattern of this kind for a stored name.
|
||||
// Pattern renders a stored name for display.
|
||||
//
|
||||
// The wildcard prefix is *not* re-added: a Set stores the prefix-free name and
|
||||
// the kind already carries the wildcard semantics, so the stored form is the
|
||||
// form a caller wrote. Use WireName when the prefixed form is needed — to hand
|
||||
// a rule back to the API, for instance.
|
||||
func (k PatternKind) Pattern(name string) string {
|
||||
return name
|
||||
}
|
||||
|
||||
// WireName renders a stored name with the wildcard prefix this kind implies.
|
||||
// It is the round-trip form: WireName(k, k.Pattern(n)) == n, and feeding it
|
||||
// back into Add reproduces the original rule.
|
||||
func (k PatternKind) WireName(name string) string {
|
||||
switch k {
|
||||
case PatternSub:
|
||||
return "*." + name
|
||||
@@ -744,8 +765,9 @@ func NewHolder(s *Set) *Holder {
|
||||
return h
|
||||
}
|
||||
|
||||
// Get returns the current set (nil before the first build).
|
||||
// Get returns the current set, or nil when nothing has been compiled yet.
|
||||
// Get returns the current set, or nil when nothing has been compiled yet. The
|
||||
// returned set is immutable and is shared with every other reader, so a caller
|
||||
// must not modify it.
|
||||
func (h *Holder) Get() *Set {
|
||||
if h == nil {
|
||||
return nil
|
||||
|
||||
Reference in new issue
Block a user