half broken

internal/engine/engine_test.go

@@ -718,11 +718,10 @@ func TestForwardedQueryShape(t *testing.T) {
 		}
 	})
 
-	// The NSID branch of prepareUpstream is deliberately not pinned here:
-	// miekg/dns v1.1.73 reports an EDNS0_NSID option as zero length, so any
-	// message carrying one fails to pack ("dns: overflow packing opt") and a
-	// client that asks for NSID gets SERVFAIL. That is a library defect, not
-	// a decision this package owns; see STATUS.md.
+	// The NSID branch of prepareUpstream is covered in pins_test.go: the
+	// option is hex on the wire (dns.EDNS0_NSID.Nsid is a hex string), a
+	// plain string there does not pack, and a client that asks for NSID
+	// used to get SERVFAIL for exactly that reason.
 }
 
 func findOption(m *dns.Msg, code uint16) dns.EDNS0 {