developer
26134ba437
The cache snapshot never loaded, so every restart was a cold cache. Snapshot
packed the whole key while Load decoded the record header out of the key's
remainder instead of the value, so every entry was skipped. The two sides are
now an explicit encodeRecord/decodeRecord pair with a version byte and a CRC-32C
trailer, so a future format change is detected instead of silently misparsed.
Load also drops entries that are already past ExpiresAt and rewrites the TTL to
the time actually left, so a served TTL never jumps back up across a restart.
Blocklist, all six gaps the failing tests were pointing at: a leading UTF-8 BOM
is stripped, "!allow example.com" works, SourceMeta exists for a source that
only ever contributed a rule, Pattern() reports the bare name again (the new
WireName() produces the wildcard form for the API), an RPZ record with no
explicit TTL inherits the zone default instead of whatever the reader left in
the RR, a hosts line with no address in the first field says so, and the
adblock parser handles CRLF and adblock-flavoured lines pasted into a plain
list. TestHolderSwapIsAtomic was asserting the wrong invariant — the swap was
always atomic, a name blocked by the old set is legitimately unblocked by the
new one.
Tests added for acl and resolver, both of which turned up real bugs:
- a PTR suffix matched across label boundaries, so a group scoped to
example.com. also swallowed ample.com. and notexample.com. — a client could
land in a group it does not belong to;
- the "*" catch-all was dropped from the rendered domain patterns, so the
engine's per-query recompile lost the "everything" case;
- Upstream.Success never closed an open breaker, so a recovered upstream stayed
excluded for the full cooldown;
- Exchange fanned out in parallel even under policy: failover.
Deploy set: go.mod requires Go 1.27.1 but CI pinned 1.23 and the Dockerfile
pinned golang:1.23-alpine, so neither could have built. The Dockerfile also
copied the source tree after the console bundle, which clobbered it.
The k8s set asked for hostNetwork with two replicas, but the server never sets
SO_REUSEPORT, so the second pod could not bind :53 and would crash-loop. It now
runs without hostNetwork behind a LoadBalancer Service, with a separate
ClusterIP Service for the Ingress (a headless Service cannot back one), a
ServiceAccount, an API-key Secret, per-pod PVCs, and a kustomization. The HPA
is gone: it cannot drive a StatefulSet. To let the API key come from that
Secret, config.Load now expands ${VAR} / ${VAR:-default} / ${NAME-default} and
fails to start on an unset variable with no default, so a missing secret is a
crash loop rather than an unauthenticated console. Expansion skips YAML
comments, so documenting ${VAR} in the ConfigMap does not break the file.
Verified: gofmt, go build, go vet clean; go test -race ./internal/... green
(acl, app, blocklist, cache, config, resolver, zonefile).
104 lines
3.0 KiB
YAML
104 lines
3.0 KiB
YAML
---
|
|
# Governing Service for the StatefulSet. Headless, and never used for traffic:
|
|
# it exists so pods get a stable DNS name, and so a PVC per pod has a home.
|
|
apiVersion: v1
|
|
kind: Service
|
|
metadata:
|
|
name: fancy-dns
|
|
namespace: dns
|
|
labels:
|
|
app.kubernetes.io/name: fancy-dns
|
|
spec:
|
|
clusterIP: None
|
|
selector:
|
|
app.kubernetes.io/name: fancy-dns
|
|
ports:
|
|
- name: dns-udp
|
|
port: 53
|
|
targetPort: dns-udp
|
|
protocol: UDP
|
|
- name: dns-tcp
|
|
port: 53
|
|
targetPort: dns-tcp
|
|
protocol: TCP
|
|
- name: dot
|
|
port: 853
|
|
targetPort: dot
|
|
- name: doh
|
|
port: 443
|
|
targetPort: doh
|
|
- name: admin
|
|
port: 8080
|
|
targetPort: admin
|
|
---
|
|
# The DNS service. This is the one clients resolve.
|
|
#
|
|
# Why a LoadBalancer and not hostNetwork: the server does not set SO_REUSEPORT,
|
|
# so two host-network pods cannot share the node's :53 and the second one
|
|
# would crash-loop on bind. Giving the cloud load balancer the port also keeps
|
|
# the node's own resolver untouched, which matters on a node that runs kubelet
|
|
# and CoreDNS.
|
|
#
|
|
# A cloud LB health-checks this Service on port 53 and needs the probe to
|
|
# actually answer a query: the default TCP check is not enough for UDP. If your
|
|
# provider supports UDP health checks, point them at 53/UDP; otherwise leave
|
|
# the load balancer health check on the HTTP admin port (see the comment on the
|
|
# web Service) and let the provider's DNS failover be the only response to a
|
|
# dead resolver.
|
|
apiVersion: v1
|
|
kind: Service
|
|
metadata:
|
|
name: fancy-dns-dns
|
|
namespace: dns
|
|
labels:
|
|
app.kubernetes.io/name: fancy-dns
|
|
annotations:
|
|
# Cloud-specific knobs go here; uncomment for the matching provider.
|
|
# service.beta.kubernetes.io/aws-load-balancer-type: nlb
|
|
# service.beta.kubernetes.io/aws-load-balancer-nlb-target-type: ip
|
|
# service.beta.kubernetes.io/gcp-load-balancer-type: EXTERNAL
|
|
spec:
|
|
type: LoadBalancer
|
|
externalTrafficPolicy: Local
|
|
selector:
|
|
app.kubernetes.io/name: fancy-dns
|
|
ports:
|
|
- name: dns-udp
|
|
port: 53
|
|
targetPort: dns-udp
|
|
protocol: UDP
|
|
- name: dns-tcp
|
|
port: 53
|
|
targetPort: dns-tcp
|
|
protocol: TCP
|
|
- name: dot
|
|
port: 853
|
|
targetPort: dot
|
|
---
|
|
# A normal ClusterIP Service for everything the Ingress fronts. It has to be a
|
|
# separate object because a headless Service has no virtual IP for an ingress
|
|
# controller to route to.
|
|
#
|
|
# It is also the only reliable health-check target for the cloud load balancers
|
|
# on fancy-dns-dns: the admin port speaks HTTP and answers /api/healthz
|
|
# unauthenticated (a health check cannot carry an API key), so a probe can tell
|
|
# "bound and serving" from "process up but not listening".
|
|
apiVersion: v1
|
|
kind: Service
|
|
metadata:
|
|
name: fancy-dns-web
|
|
namespace: dns
|
|
labels:
|
|
app.kubernetes.io/name: fancy-dns
|
|
spec:
|
|
type: ClusterIP
|
|
selector:
|
|
app.kubernetes.io/name: fancy-dns
|
|
ports:
|
|
- name: doh
|
|
port: 443
|
|
targetPort: doh
|
|
- name: admin
|
|
port: 8080
|
|
targetPort: admin
|