diff --git a/cmd/cart/mutation_add_request.go b/cmd/cart/mutation_add_request.go deleted file mode 100644 index 554546f..0000000 --- a/cmd/cart/mutation_add_request.go +++ /dev/null @@ -1,51 +0,0 @@ -package main - -// mutation_add_request.go -// -// Registers the AddRequest mutation. This mutation is a higher-level intent -// (add by SKU + quantity) which may translate into either: -// - Increasing quantity of an existing line (same SKU), OR -// - Creating a new item by performing a product lookup (via getItemData inside CartGrain.AddItem) -// -// Behavior: -// - Validates non-empty SKU and quantity > 0 -// - If an item with the SKU already exists: increments its quantity -// - Else delegates to CartGrain.AddItem (which itself produces an AddItem mutation) -// - Totals recalculated automatically (WithTotals) -// -// NOTE: -// - This handler purposely avoids duplicating the detailed AddItem logic; -// it reuses CartGrain.AddItem which then flows through the AddItem mutation -// registry handler. -// - Double total recalculation can occur (AddItem has WithTotals too), but -// is acceptable for clarity. Optimize later if needed. -// -// Potential future improvements: -// - Stock validation before increasing quantity -// - Reservation logic or concurrency guards around stock updates -// - Coupon / pricing rules applied conditionally during add-by-sku - -// func HandleAddRequest(g *CartGrain, m *messages.AddRequest) error { -// if m == nil { -// return fmt.Errorf("AddRequest: nil payload") -// } -// if m.Sku == "" { -// return fmt.Errorf("AddRequest: sku is empty") -// } -// if m.Quantity < 1 { -// return fmt.Errorf("AddRequest: invalid quantity %d", m.Quantity) -// } - -// // Existing line: accumulate quantity only. -// if existing, found := g.FindItemWithSku(m.Sku); found { -// existing.Quantity += int(m.Quantity) -// return nil -// } -// data, err := GetItemAddMessage(m.Sku, int(m.Quantity), m.Country, m.StoreId) -// if err != nil { -// return err -// } -// return AddItem(g, data) - -// return err -// } diff --git a/cmd/cart/pool-server.go b/cmd/cart/pool-server.go index 5dc825a..ec9de43 100644 --- a/cmd/cart/pool-server.go +++ b/cmd/cart/pool-server.go @@ -182,10 +182,15 @@ func (s *PoolServer) HandleAddRequest(w http.ResponseWriter, r *http.Request, id if err != nil { return err } - reply, err := s.ApplyLocal(id, &addRequest) + msg, err := GetItemAddMessage(addRequest.Sku, int(addRequest.Quantity), addRequest.Country, addRequest.StoreId) if err != nil { return err } + reply, err := s.ApplyLocal(id, msg) + if err != nil { + return err + } + return s.WriteResult(w, reply) } diff --git a/proto/messages.proto b/proto/messages.proto index 52d09ab..1640d81 100644 --- a/proto/messages.proto +++ b/proto/messages.proto @@ -9,8 +9,8 @@ message AddRequest { optional string storeId = 4; } -message SetCartRequest { - repeated AddRequest items = 1; +message ClearCartRequest { + } message AddItem {