From 0fde8a0f92ebeb975ce0076549e639748bc8ccb9 Mon Sep 17 00:00:00 2001 From: matst80 Date: Sat, 19 Sep 2026 08:57:09 +0000 Subject: [PATCH] Quick polish pass on remaining screens; hide legacy chrome on RUM tab Normalize radii, drop shadows/blur and font-black, and document the one-view-at-a-time plan in AGENTS.md. Co-Authored-By: Claude Sonnet 5 --- AGENTS.md | 9 ++++- otel-ui/src/App.tsx | 2 +- otel-ui/src/components/CommandAndQueryBar.tsx | 8 ++--- otel-ui/src/components/GaugeMeter.tsx | 10 +++--- otel-ui/src/components/MetricsVisualizer.tsx | 12 +++---- otel-ui/src/components/NeedleTestModal.tsx | 6 ++-- otel-ui/src/components/PatternsVisualizer.tsx | 2 +- otel-ui/src/components/RolloutsVisualizer.tsx | 2 +- otel-ui/src/components/SearchAndWatcher.tsx | 16 ++++----- otel-ui/src/components/ServiceGraph.tsx | 2 +- otel-ui/src/components/SetupPanel.tsx | 4 +-- .../src/components/StructuredLogTerminal.tsx | 8 ++--- otel-ui/src/components/Tabs.tsx | 2 +- otel-ui/src/components/TraceVisualization.tsx | 36 +++++++++---------- otel-ui/src/components/TrendsVisualizer.tsx | 10 +++--- otel-ui/src/components/ViewErrorBoundary.tsx | 4 +-- otel-ui/src/components/WaveformHistogram.tsx | 6 ++-- 17 files changed, 73 insertions(+), 66 deletions(-) diff --git a/AGENTS.md b/AGENTS.md index c40611d..9a0d9d9 100644 --- a/AGENTS.md +++ b/AGENTS.md @@ -153,7 +153,7 @@ Lessons from getting here: `SearchAndWatcher`, `TrendsVisualizer`, `SetupPanel`. They use `ds-*` colors via a mechanical token swap but keep their old layout/type scale, use `onClick` on non-buttons in places, and `CommandAndQueryBar` / - `WaveformHistogram` still sit above every non-Issues/RUM tab. Restructure + `WaveformHistogram` still sit above every tab except Issues and RUM sessions (`isTriageOverview` in `App.tsx`). Restructure them onto `FilterBar` + the card/aside pattern when touching them. ### Finding old-pattern usages @@ -164,3 +164,10 @@ grep -rnE "(bg|text|border|ring|from|to|via)-(slate|zinc|gray|sky|cyan|blue|viol ``` Both must print nothing. + +### Working order from here + +Initial pass is done. Take **one view at a time** to the full screen pattern +(FilterBar + card/aside layout, real buttons, fold or restyle the shared +chrome for that screen), verify it in the browser in both themes, commit, then +move to the next. Suggested order: Traces, Logs, Metrics, Search, Trends, Setup. diff --git a/otel-ui/src/App.tsx b/otel-ui/src/App.tsx index 3205344..0abab6a 100644 --- a/otel-ui/src/App.tsx +++ b/otel-ui/src/App.tsx @@ -73,7 +73,7 @@ function App() { // The Issues tab is the redesigned triage overview: it owns its own filter // bar and cards, so the legacy anomaly banner and volume waveform above it // would just duplicate that UI in a different visual language. - const isTriageOverview = activeTab === "tab0"; + const isTriageOverview = activeTab === "tab0" || activeTab === "tab7"; if (isCallback) { return ; diff --git a/otel-ui/src/components/CommandAndQueryBar.tsx b/otel-ui/src/components/CommandAndQueryBar.tsx index 37278b8..3d4e722 100644 --- a/otel-ui/src/components/CommandAndQueryBar.tsx +++ b/otel-ui/src/components/CommandAndQueryBar.tsx @@ -102,7 +102,7 @@ export const CommandAndQueryBar: React.FC = () => {
{/* Real Anomaly Radar Banner */} {(errorStats.errorCount > 0 || topOpenIssue) && ( -
+